Fix resolving re-defined with factory dependencies #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
Tests: 26, Assertions: 61, Errors: 2, Failures: 5. |
Contributor
Author
|
@yiiliveext, yes, I know it. It is not related to this PR. See issue #6. |
Contributor
See my alternative PR (#8). |
Contributor
Author
|
Maybe #8 is even better than this PR because it allows to check not only explicitly set definitions. So, as conclusion I can say that there is really no need to use |
Contributor
I agree. On my PR all tests have been passing.
I agree you are right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR potentially replaces another one.