Conversation
Member
vjik
commented
Mar 15, 2026
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Fix #247 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 827 827
===========================================
Files 89 89
Lines 2225 2225
===========================================
Hits 2225 2225 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR standardizes terminology in the Html helper API by renaming the $options parameter to $attributes for CSS class/style helper methods (a BC break impacting named-argument callers), aligning with broader attribute naming across the codebase.
Changes:
- Renamed the by-ref parameter in
Html::addCssClass(),Html::removeCssClass(),Html::addCssStyle(), andHtml::removeCssStyle()from$optionsto$attributes. - Updated related documentation (inline docs, upgrade notes, changelog) to reflect the rename and BC impact.
- Updated unit tests to use
$attributesvariable naming for these helpers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Html.php |
Renames method parameters and updates docblocks/examples to $attributes. |
tests/HtmlTest.php |
Updates tests’ variable/parameter naming to match $attributes. |
UPGRADE.md |
Documents the BC break for named-argument callers. |
CHANGELOG.md |
Records the change under the upcoming release notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Tigrov
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.