Skip to content

Cleanup and refactoring #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samdark merged 34 commits into from
Nov 25, 2020
Merged

Cleanup and refactoring #49

samdark merged 34 commits into from
Nov 25, 2020

Conversation

@devanych
Copy link
Member

@devanych devanych commented Nov 22, 2020

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues -

@devanych
Copy link
Member Author

devanych commented Nov 22, 2020 •
edited
Loading

Need overall benchmark to ensure logger doesn't consume CPU/memory more than it was before refactoring. That is critical framework component in this regard.

https://github.com/devanych/yii-log-benchmark

@samdark
Copy link
Member

samdark commented Nov 23, 2020

Benchmark doesn't reveal anything critical about refactoring.

@devanych devanych marked this pull request as ready for review November 24, 2020 11:19
@samdark
Copy link
Member

samdark commented Nov 24, 2020

@devanych would you please resolve conflicts?

@samdark samdark changed the title New demo feature Cleanup and refactorin Nov 24, 2020
@samdark samdark changed the title Cleanup and refactorin Cleanup and refactoring Nov 24, 2020
@samdark samdark added the status:code review The pull request needs review. label Nov 24, 2020
@samdark samdark requested a review from a team November 24, 2020 23:03
samdark
samdark requested changes Nov 24, 2020
View reviewed changes
@devanych devanych requested a review from samdark November 25, 2020 08:17
@samdark samdark merged commit 4c080f7 into yiisoft:master Nov 25, 2020
@samdark
Copy link
Member

samdark commented Nov 25, 2020

👍

@devanych devanych deleted the new-demo-feature branch December 8, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samdark samdark samdark approved these changes

Assignees

No one assigned

Labels

status:code review The pull request needs review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devanych @samdark