Skip to content

Add PredefinedQueueProvider#264

Merged
vjik merged 5 commits intomasterfrom
predefined-queue-provider
Mar 17, 2026
Merged

Add PredefinedQueueProvider#264
vjik merged 5 commits intomasterfrom
predefined-queue-provider

Conversation

@vjik
Copy link
Member

@vjik vjik commented Mar 15, 2026

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Tests pass? ✔️

@vjik vjik requested a review from a team March 15, 2026 17:30
@vjik vjik added the status:code review The pull request needs review. label Mar 15, 2026
@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (57c3fe7) to head (1e5b8d0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #264      +/-   ##
============================================
+ Coverage     98.54%   98.57%   +0.02%     
- Complexity      360      366       +6     
============================================
  Files            47       48       +1     
  Lines           964      983      +19     
============================================
+ Hits            950      969      +19     
  Misses           14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new queue provider implementation that returns queues from a preconfigured in-memory map, enabling simple composition and testing scenarios without factories/containers.

Changes:

  • Introduced PredefinedQueueProvider implementing QueueProviderInterface using a name→instance map with enum name normalization.
  • Added unit tests covering get(), has(), not-found behavior, invalid config, and enum-backed names.
  • Updated CompositeQueueProviderTest to use PredefinedQueueProvider for simpler provider composition.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Provider/PredefinedQueueProvider.php New provider that returns predefined QueueInterface instances by normalized name.
tests/Unit/Provider/PredefinedQueueProviderTest.php New test suite validating provider behavior and error cases.
tests/Unit/Provider/CompositeQueueProviderTest.php Refactors composite provider test to compose predefined providers instead of adapter-factory providers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vjik vjik merged commit 37141e6 into master Mar 17, 2026
31 of 33 checks passed
@vjik vjik deleted the predefined-queue-provider branch March 17, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants