Conversation
Member
vjik
commented
May 1, 2026
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Tests pass? | ✔️ |
There was a problem hiding this comment.
Pull request overview
Refactors the push middleware execution path to avoid nested dispatching by pre-combining base dispatcher middleware with queue-specific middleware, updating integration coverage to validate the full composed pipeline order.
Changes:
Queuenow prepares a per-queue push dispatcher by combining base dispatcher middleware with queue-specific middleware.PushMiddlewareDispatcheraddswithMiddlewaresAdded()to append middleware definitions to an existing dispatcher instance.- Integration test updates the expected push middleware stack to cover additional appended middleware.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Integration/MiddlewareTest.php | Extends the integration test to validate appended push middleware order with an extra stage. |
| src/Queue.php | Switches push dispatching to a prepared combined dispatcher and removes the nested dispatcher handler. |
| src/Middleware/Push/PushMiddlewareDispatcher.php | Adds withMiddlewaresAdded() API for appending middleware definitions and adjusts callable signature docs for push middleware. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
viktorprogger
approved these changes
May 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
============================================
- Coverage 98.38% 98.37% -0.02%
- Complexity 321 322 +1
============================================
Files 47 47
Lines 868 860 -8
============================================
- Hits 854 846 -8
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.