Skip to content

PHP 8.4 support + Improve debug message in LogginMiddleware#109

Merged
vjik merged 3 commits intomasterfrom
php84
Feb 24, 2025
Merged

PHP 8.4 support + Improve debug message in LogginMiddleware#109
vjik merged 3 commits intomasterfrom
php84

Conversation

@vjik
Copy link
Copy Markdown
Member

@vjik vjik commented Feb 23, 2025

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fix #108

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (ab42e9e) to head (759f547).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #109   +/-   ##
=========================================
  Coverage     99.65%   99.66%           
- Complexity      108      110    +2     
=========================================
  Files            15       15           
  Lines           294      298    +4     
=========================================
+ Hits            293      297    +4     
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team February 23, 2025 17:28
@vjik vjik added the status:code review The pull request needs review. label Feb 23, 2025
@vjik vjik merged commit 747b56c into master Feb 24, 2025
@vjik vjik deleted the php84 branch February 24, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$guestIdentityFactory as nullable is deprecated in CurrentUser::__construct

2 participants