Skip to content

Test "enableIdn" option with no intl extension available (Email, Url rules) #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arogachev wants to merge 2 commits into from
Closed

Test "enableIdn" option with no intl extension available (Email, Url rules) #209

arogachev wants to merge 2 commits into from

Conversation

@arogachev
Copy link
Contributor

@arogachev arogachev commented Apr 12, 2022 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues #202

@arogachev arogachev requested a review from a team April 12, 2022 16:38
@arogachev arogachev self-assigned this Apr 12, 2022
@arogachev arogachev added type:task Task status:code review The pull request needs review. labels Apr 12, 2022
@arogachev arogachev linked an issue Apr 12, 2022 that may be closed by this pull request
Add test for Email rule when intl extension is not available #202
Closed
@arogachev arogachev marked this pull request as draft April 13, 2022 12:15
arogachev
arogachev commented Apr 13, 2022
View reviewed changes
src/Rule/Email.php

declare(strict_types=1);

namespace Yiisoft\Validator\Rule;
Copy link
Contributor Author

@arogachev arogachev Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was decided to use CI instead.

@xepozz
Copy link
Member

xepozz commented Jul 19, 2022

Could it be done with

validator/tests/bootstrap.php

Line 8 in ea9d527

class FunctionExists
?

@arogachev
Copy link
Contributor Author

arogachev commented Jul 26, 2022 •
edited
Loading

@xepozz Nope, it couldn't. Checked it again. This method only works once for Url rule. Already faced this problem.

@arogachev
Copy link
Contributor Author

arogachev commented Jul 26, 2022

Closing in favor of #277.

@arogachev arogachev closed this Jul 26, 2022
@samdark samdark deleted the 202-enable-idn-with-no-intl branch July 26, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arogachev arogachev

Labels

status:code review The pull request needs review. type:task Task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add test for Email rule when intl extension is not available

4 participants

@arogachev @xepozz @StyleCIBot