Fix incorrect operation Each (new Nested) rule for iterable of objects#768
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #768 +/- ##
============================================
+ Coverage 94.40% 96.18% +1.78%
- Complexity 953 1035 +82
============================================
Files 108 122 +14
Lines 3018 3274 +256
============================================
+ Hits 2849 3149 +300
+ Misses 169 125 -44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Currently this case can be resolved by new Each(new Nested()), but it's not available as attribute. And it requires implement RulesProviderInterface and place rule in getRules() method, it's not convenient.
Whole, I like this suggestion.
@arogachev @samdark WDYT?
|
The idea is very good 👍 Need a bit more for it to be merged:
|
|
Отказался от |
|
Oh, creating objects for attribute parameters is available from PHP 8.1. Yes. |
|
И еще, теперь думаю это не |
vjik
left a comment
There was a problem hiding this comment.
Yes, now this is bugfix. Add line to changelog.
Each (new Nested) rule for iterable of objects
|
Thank you! |
Uh oh!
There was an error while loading. Please reload this page.