Fix #793: Fix translations, broken link in contributing guide, incorrect imports and grammar in documentation#793
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #793 +/- ##
============================================
+ Coverage 94.40% 96.03% +1.63%
- Complexity 953 1044 +91
============================================
Files 108 122 +14
Lines 3018 3230 +212
============================================
+ Hits 2849 3102 +253
+ Misses 169 128 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates validator message templates and translations, fixes documentation examples/imports, and aligns date/time handler error wording with the new message format.
Changes:
- Update Date/DateTime/Time handler default messages from “no early/late than” to “no earlier/later than” and adjust related tests.
- Refresh multiple locale translation files to match updated rule messages/placeholders and add missing rule messages.
- Fix docs: broken contributing link, corrected compare-rule code sample imports, and improved Result page wording (plus updated PO/POT sources).
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.github/CONTRIBUTING.md |
Updates development tool documentation link. |
docs/guide/en/built-in-rules-compare.md |
Fixes imports in the Compare rule example snippet. |
docs/guide/en/result.md |
Fixes grammar in Result page intro sentence. |
docs/guide/ru/built-in-rules-compare.md |
Updates code snippet imports to match English guide changes. |
docs/guide/ru/result.md |
Regenerated RU guide currently shows English sentence due to PO state. |
docs/po/built-in-rules-compare.md/built-in-rules-compare.md.pot |
Updates POT with corrected imports snippet. |
docs/po/built-in-rules-compare.md/ru/built-in-rules-compare.md.ru.po |
Updates RU PO for Compare docs (currently has fuzzy/out-of-sync code block). |
docs/po/result.md/result.md.pot |
Updates POT with corrected Result intro sentence. |
docs/po/result.md/ru/result.md.ru.po |
Updates RU PO for Result docs (currently marked fuzzy). |
messages/de/yii-validator.php |
Updates German validator messages / adds new rule messages. |
messages/pl/yii-validator.php |
Updates Polish validator messages / adds new rule messages. |
messages/pt-BR/yii-validator.php |
Updates Portuguese (Brazil) validator messages / adds new rule messages. |
messages/ru/yii-validator.php |
Updates Russian validator messages / adds new rule messages and fixes typos. |
messages/uz/yii-validator.php |
Updates Uzbek validator messages / adds new rule messages. |
src/Rule/Date/DateHandler.php |
Updates default min/max violation message wording. |
src/Rule/Date/DateTimeHandler.php |
Updates default min/max violation message wording. |
src/Rule/Date/TimeHandler.php |
Updates default min/max violation message wording. |
tests/Rule/Date/DateTest.php |
Updates expected messages to match new wording. |
tests/Rule/Date/DateTimeTest.php |
Updates expected messages to match new wording. |
tests/Rule/Date/TimeTest.php |
Updates expected messages to match new wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Please add a line for CHANGELOG. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Thank you! |
What does this PR do?
Summary
AnyRule,FilledOnlyOneOf,Image,UniqueIterable,Uuid,StringValue, type rules, Date/DateTime/Timerules) and aligned messages with updated placeholders (
{type},{property})CONTRIBUTING.mdpointing to the development tool docs (005-development-tool.mdmoved undersrc/internals/)docs/guide/en/built-in-rules-compare.md— replaced unusedCallback,GreaterThanOrEqual,LessThanOrEqualwith actually usedDateInterval,GreaterThan,LessThandocs/guide/en/result.md("containing of errors" → "containing errors that occurred")Files changed
.github/CONTRIBUTING.md— fix broken docs linkdocs/guide/en/built-in-rules-compare.md— fix wrong imports in code exampledocs/guide/en/result.md— fix grammarmessages/{de,pl,pt-BR,ru,uz}/yii-validator.php— update translationssrc/Rule/Date/{DateHandler,DateTimeHandler,TimeHandler}.php— update message formattests/Rule/Date/{DateTest,DateTimeTest,TimeTest}.php— update expected messages in tests