Skip to content

Fix #793: Fix translations, broken link in contributing guide, incorrect imports and grammar in documentation#793

Merged
samdark merged 11 commits intoyiisoft:masterfrom
EvilKarter:master
Apr 21, 2026
Merged

Fix #793: Fix translations, broken link in contributing guide, incorrect imports and grammar in documentation#793
samdark merged 11 commits intoyiisoft:masterfrom
EvilKarter:master

Conversation

@EvilKarter
Copy link
Copy Markdown
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

What does this PR do?

Summary

  • Updated translation files (de, pl, pt-BR, ru, uz) to include new and updated validation messages for new rules (AnyRule, FilledOnlyOneOf, Image, UniqueIterable, Uuid, StringValue, type rules, Date/DateTime/Time
    rules) and aligned messages with updated placeholders ({type}, {property})
  • Fixed broken link in CONTRIBUTING.md pointing to the development tool docs (005-development-tool.md moved under src/internals/)
  • Fixed incorrect imports in docs/guide/en/built-in-rules-compare.md — replaced unused Callback, GreaterThanOrEqual, LessThanOrEqual with actually used DateInterval, GreaterThan, LessThan
  • Fixed grammar error in docs/guide/en/result.md ("containing of errors" → "containing errors that occurred")
  • Fixed Date/DateTime/Time handlers and tests to use updated message format

Files changed

  • .github/CONTRIBUTING.md — fix broken docs link
  • docs/guide/en/built-in-rules-compare.md — fix wrong imports in code example
  • docs/guide/en/result.md — fix grammar
  • messages/{de,pl,pt-BR,ru,uz}/yii-validator.php — update translations
  • src/Rule/Date/{DateHandler,DateTimeHandler,TimeHandler}.php — update message format
  • tests/Rule/Date/{DateTest,DateTimeTest,TimeTest}.php — update expected messages in tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.03%. Comparing base (fe63447) to head (9ee9e05).
⚠️ Report is 99 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #793      +/-   ##
============================================
+ Coverage     94.40%   96.03%   +1.63%     
- Complexity      953     1044      +91     
============================================
  Files           108      122      +14     
  Lines          3018     3230     +212     
============================================
+ Hits           2849     3102     +253     
+ Misses          169      128      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/CONTRIBUTING.md Outdated
@samdark samdark requested review from Copilot and vjik March 25, 2026 19:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates validator message templates and translations, fixes documentation examples/imports, and aligns date/time handler error wording with the new message format.

Changes:

  • Update Date/DateTime/Time handler default messages from “no early/late than” to “no earlier/later than” and adjust related tests.
  • Refresh multiple locale translation files to match updated rule messages/placeholders and add missing rule messages.
  • Fix docs: broken contributing link, corrected compare-rule code sample imports, and improved Result page wording (plus updated PO/POT sources).

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.github/CONTRIBUTING.md Updates development tool documentation link.
docs/guide/en/built-in-rules-compare.md Fixes imports in the Compare rule example snippet.
docs/guide/en/result.md Fixes grammar in Result page intro sentence.
docs/guide/ru/built-in-rules-compare.md Updates code snippet imports to match English guide changes.
docs/guide/ru/result.md Regenerated RU guide currently shows English sentence due to PO state.
docs/po/built-in-rules-compare.md/built-in-rules-compare.md.pot Updates POT with corrected imports snippet.
docs/po/built-in-rules-compare.md/ru/built-in-rules-compare.md.ru.po Updates RU PO for Compare docs (currently has fuzzy/out-of-sync code block).
docs/po/result.md/result.md.pot Updates POT with corrected Result intro sentence.
docs/po/result.md/ru/result.md.ru.po Updates RU PO for Result docs (currently marked fuzzy).
messages/de/yii-validator.php Updates German validator messages / adds new rule messages.
messages/pl/yii-validator.php Updates Polish validator messages / adds new rule messages.
messages/pt-BR/yii-validator.php Updates Portuguese (Brazil) validator messages / adds new rule messages.
messages/ru/yii-validator.php Updates Russian validator messages / adds new rule messages and fixes typos.
messages/uz/yii-validator.php Updates Uzbek validator messages / adds new rule messages.
src/Rule/Date/DateHandler.php Updates default min/max violation message wording.
src/Rule/Date/DateTimeHandler.php Updates default min/max violation message wording.
src/Rule/Date/TimeHandler.php Updates default min/max violation message wording.
tests/Rule/Date/DateTest.php Updates expected messages to match new wording.
tests/Rule/Date/DateTimeTest.php Updates expected messages to match new wording.
tests/Rule/Date/TimeTest.php Updates expected messages to match new wording.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/guide/ru/result.md
Comment thread docs/po/result.md/ru/result.md.ru.po
Comment thread docs/po/built-in-rules-compare.md/ru/built-in-rules-compare.md.ru.po Outdated
@samdark
Copy link
Copy Markdown
Member

samdark commented Mar 25, 2026

Please add a line for CHANGELOG.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 10, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 392e9c26-8ad3-418e-8431-47e792d52920

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

samdark and others added 2 commits April 21, 2026 13:16
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@samdark samdark changed the title Fix translations, broken link, and incorrect imports in docs Fix #793: Fix translations, broken link in contributing guide, incorrect imports and grammar in documentation Apr 21, 2026
@samdark samdark merged commit 8aa021d into yiisoft:master Apr 21, 2026
36 of 37 checks passed
@samdark
Copy link
Copy Markdown
Member

samdark commented Apr 21, 2026

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants