EmailValidator with IDN fails on hyphen #94
Conversation
mapeveri
commented
Nov 22, 2020
mapeveri
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | #2 |
|
It seems to break tests: https://github.com/yiisoft/validator/runs/1438130363 |
samdark
added
status:under development
|
@samdark Yep, the problem is with this emails:
I commeted the email with problems in the test. Any idea why this email passed the filter_var? Thanks |
|
@mapeveri seems that filter_var isn't suitable for the purpose: https://3v4l.org/4oslP |
|
filter_var is RFC 5321 and we need way stricter validation. |
|
@samdark What validation do you recommend? |
|
Regular expressions. Simplistic ones. |
|
@samdark thanks. I updated this PR :) |
src/Rule/Email.php
Outdated
| } | ||
|
|
||
| if ($this->enableIDN && $valid === false) { | ||
| $pattern = '/^([a-zA-Z0-9._%+-]+)@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.)|(([\w-]+\.)+))([a-zA-Z]{2,4}|[0-9]{1,3})(\]?)$/'; |
There was a problem hiding this comment.
That could be moved to a customizable property same as other regex patterns.
There was a problem hiding this comment.
@samdark there is a private pattern regex, maybe a new property $patternIdnEmail as a private property, is ok?
samdark
added
status:code review
|
Thank you! |
2 participants
