Skip to content

Cleanup#295

Merged
samdark merged 4 commits intomasterfrom
cleanup
Jan 8, 2026
Merged

Cleanup#295
samdark merged 4 commits intomasterfrom
cleanup

Conversation

@samdark
Copy link
Copy Markdown
Member

@samdark samdark commented Jan 6, 2026

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copilot AI review requested due to automatic review settings January 6, 2026 21:41
@samdark samdark unassigned vjik Jan 6, 2026
@samdark samdark requested a review from vjik January 6, 2026 21:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.50%. Comparing base (7ed8d9c) to head (3d5fb97).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #295      +/-   ##
============================================
- Coverage     99.50%   99.50%   -0.01%     
  Complexity      305      305              
============================================
  Files            19       19              
  Lines           801      800       -1     
============================================
- Hits            797      796       -1     
  Misses            4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR contains code cleanup refactorings including test improvements, code simplifications, and spelling fixes. However, it introduces critical bugs in how CacheKeyNormalizer::normalize() is called.

Key changes:

  • Improved PHPUnit assertions and added missing return type declarations in tests
  • Simplified control flow and removed unnecessary function indirection in ViewTrait
  • Fixed Cyrillic character spelling error in documentation
  • CRITICAL: Incorrectly changed instance method calls to static method syntax for CacheKeyNormalizer::normalize()

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/ViewTest.php Improved test assertions and added missing return type declaration
tests/CachedContentTest.php Attempted to change normalize() call to static syntax (introduces bug)
src/ViewTrait.php Removed call_user_func usage, simplified control flow, removed unused import
src/Cache/CachedContent.php Attempted to change normalize() call to static syntax (introduces bug)
docs/guide/en/use-in-web-environment.md Fixed Cyrillic 'С' to Latin 'C' in "CSS"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Cache/CachedContent.php Outdated
Comment thread tests/CachedContentTest.php Outdated
Copy link
Copy Markdown
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line to changelog

Comment thread src/Cache/CachedContent.php Outdated
Comment thread tests/CachedContentTest.php Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.md
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@samdark samdark merged commit 455b8e6 into master Jan 8, 2026
25 of 26 checks passed
@samdark samdark deleted the cleanup branch January 8, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants