Conversation
samdark
commented
Jan 6, 2026
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | - |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
============================================
- Coverage 99.50% 99.50% -0.01%
Complexity 305 305
============================================
Files 19 19
Lines 801 800 -1
============================================
- Hits 797 796 -1
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR contains code cleanup refactorings including test improvements, code simplifications, and spelling fixes. However, it introduces critical bugs in how CacheKeyNormalizer::normalize() is called.
Key changes:
- Improved PHPUnit assertions and added missing return type declarations in tests
- Simplified control flow and removed unnecessary function indirection in ViewTrait
- Fixed Cyrillic character spelling error in documentation
- CRITICAL: Incorrectly changed instance method calls to static method syntax for
CacheKeyNormalizer::normalize()
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ViewTest.php | Improved test assertions and added missing return type declaration |
| tests/CachedContentTest.php | Attempted to change normalize() call to static syntax (introduces bug) |
| src/ViewTrait.php | Removed call_user_func usage, simplified control flow, removed unused import |
| src/Cache/CachedContent.php | Attempted to change normalize() call to static syntax (introduces bug) |
| docs/guide/en/use-in-web-environment.md | Fixed Cyrillic 'С' to Latin 'C' in "CSS" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>