Skip to content

simplified syntax for specifying Collapse widget $items #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 16, 2017
Merged

simplified syntax for specifying Collapse widget $items #200

merged 5 commits into from
Apr 16, 2017

Conversation

@cebe
Copy link
Member

@cebe cebe commented Apr 14, 2017

Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Tests pass? yes
Fixed issues fixes #64

@cebe cebe added the type:enhancement Enhancement label Apr 14, 2017
@cebe cebe added this to the 2.0.7 milestone Apr 14, 2017
@cebe cebe mentioned this pull request Apr 14, 2017
Closed
@Faryshta
Copy link

Faryshta commented Apr 16, 2017

looks great. how about the Tabs widget? or other widgets that use tabs

@samdark samdark merged commit 0a549a5 into master Apr 16, 2017
@samdark samdark deleted the collapse-items branch April 16, 2017 23:46
@samdark
Copy link
Member

samdark commented Apr 16, 2017

Merged. Thank you!

@cebe
Copy link
Member Author

cebe commented Apr 18, 2017

looks great. how about the Tabs widget? or other widgets that use tabs

feel free to work on that if you have time, sounds like a useful addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samdark samdark samdark approved these changes

Assignees

No one assigned

Labels

type:enhancement Enhancement

Projects

None yet

Milestone

2.0.7

Development

Successfully merging this pull request may close these issues.

for Collapse, tabs and other widgets that require label, let the key on the $items property be the label by default

4 participants

@cebe @Faryshta @samdark