Revert PR 528

[luke-]

Q	A
Is bugfix?	✔️
Fixed issues	PR #528

Reverts PR #528

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.47%. Comparing base (5be821e) to head (1915948).

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #550      +/-   ##
============================================
- Coverage     46.54%   46.47%   -0.08%     
+ Complexity      506      501       -5     
============================================
  Files            44       44              
  Lines          1579     1575       -4     
============================================
- Hits            735      732       -3     
+ Misses          844      843       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rob006]

This should target 2.x line. Master is going to be released as 3.0.0

[luke-]

@rob006 Thanks, is there a branch for the 2.x line?

[s1lver]

I think we could rollback already in version 3.0. Or make a hotfix from 2.3.8

[luke-]

Both options would be fine for me.

[rob006]

This should be fixed in patch release - probably a lot of people will stuck on 2.x line and we shouldn't leave it with this bug.

[s1lver]

This should be fixed in patch release - probably a lot of people will stuck on 2.x line and we shouldn't leave it with this bug.

2.3.8.1 or 2.3.9 ?

[rob006]

IMO it should be 2.3.9, but AFAIK both will work.