Db traits

[cebe]

• Move commonly used functions of Query, ActiveQuery and ActiveRelation to traits
• Make ActiveRelation class configurable in AR diff
• where to put the SORT_ASC and SORT_DESC constants?
• adjust class and trait documentation

I created a BaseQuery in yii\db that supports where, limit, offset, orderBy and indexBy. These are imo the basic operations that have to be implemented by a dbms. This is also everything that is needed by dataprovider and gridview.

[coveralls]

Coverage remained the same when pulling 3130aad on db-traits into 155e9c6 on master.

[coveralls]

Coverage decreased (-0.1%) when pulling 3130aad on db-traits into 155e9c6 on master.

[cebe]

where to put the SORT_ASC and SORT_DESC constants?

Can't we just reuse the PHP constants SORT_ASC and SORT_DESC?
http://php.net/manual/en/array.constants.php
Not perfect because one can not use true and false anymore but imo using true and false is not good practice anyway as it is not clear which value is asc and which desc.

I tried to do it with namespaced constants that are accessable like yii\db\SORT_ASC but we become problems here with autoloading because it is not possible to use the constant before BaseQuery has been autoloaded.

[cebe]

defining constant in a trait is not possible btw.

[qiangxue]

Moved to beta milestone. I'm still not quite sure about this...

[cebe]

Further Todo:

• Rename traits and create interfaces: QueryTrait, QueryInterface, ActiveRelationInterface
• Use PHP SORT_ASC and SORT_DESC

[cebe]

This is the current structure of db classes now:

The PHPdoc got duplicated now as it is once in the interface and once in the trait. need to clean that up later (best when we have api doc generator to see where @inheritdoc takes documentation from when we implement interface and use a trait at the same time).

[cebe]

• Need to add some tests for ActiveDataProvider to ensure it works as expected.

[coveralls]

Coverage decreased (-0.16%) when pulling 6533897 on db-traits into 0eaafd7 on master.

[qiangxue]

...implemented by active query classes?

[qiangxue]

What about ActiveRecord? Is it possible to extract an interface and/or a trait?

[coveralls]

Coverage remained the same when pulling 9448c3d on db-traits into 0eaafd7 on master.

[cebe]

What about ActiveRecord? Is it possible to extract an interface and/or a trait?

As I said in discussion yesterday I'd like to do that later when I implemented redis and elasticsearch to see what is the common part.

[coveralls]

Coverage decreased (-0.01%) when pulling 51faa62 on db-traits into 0eaafd7 on master.

[coveralls]

Coverage remained the same when pulling 1acdbb7 on db-traits into 0eaafd7 on master.

[cebe]

Should be all fine now except the count() signature issue.

[coveralls]

Coverage remained the same when pulling 8250cfb on db-traits into 0eaafd7 on master.

[qiangxue]

Everything looks good to me. Thanks for the great work!

[qiangxue]

How about rename yii/ar to yii/query and move QueryInterface and QueryTrait into that directory too?

[qiangxue]

Actually, perhaps we should put all these interfaces and traits under yii/db. They are all part of DB support in general. Having a separate directory such as yii\ar or yii\query could cause confusion.

[cebe]

I initially thought about having the db independend ActiveRecord classes in yii\ar and the SQL-DB specific things in yii\db. But as yii\ar\ActiveQueryInterface extends from yii\db\QueryInterface and ActiveQuery interface is then again implemented in yii\db it is better to have them all in yii\db imo. I also tend to putting redis elasticsearch and others also under yii/db. But that decision can be made when they are ready.

[qiangxue]

Yes, let's put these interfaces and traits under yii\db.

For elasticsearch and other DB solutions, I think we should put them directly under yii. If they have external dependencies, we could even consider putting them under yii/extensions.

[qiangxue]

FYI, I have moved the traits/interfaces back to yii/db.

[klimov-paul]

I have some concerns:

• Shouldn’t “ActiveRelationInterface” have a “findWith()” method?
• It would be nice, if we have “ActiveRecordInterface” (another possible name: “ActiveRelationContainerInterface”). In this case code “ActiveRelationTrait::findWith()” can be unified: see lines 108, 127.