Using only arrays in rules instead comma-separated string

[slavcodev]

I think the short form of array is not difficult to write than a comma separated string. But we gain a little bit in performance when creating each model instance.

public function rules()
{
    return [
        [['name', 'email', 'subject', 'body'], 'required'],
    ];
}

vs

public function rules()
{
    return [
        ['name, email, subject, body', 'required'],
    ];
}

[coveralls]

Coverage decreased (-0.01%) when pulling 1c2489a on slavcodev:only-arrays-in-rules into 6066c29 on yiisoft:master.

[qiangxue]

'username' is fine in this case. Should also fix Gii model generator.

[slavcodev]

Yes single attribute may be as string, but I think it is not necessary to teach programmers to poor :)
I would even removed the conversion to the array for consistency

[slavcodev]

I remove conversion to array and add type hinting into Validator::createValidator, please tell me your opinion.

[cebe]

Imo it should be possible to specify one attribute without brackets. I see no sense in having to add [] each time when one attribute rule is specified. Nearly 3/4 of the rules I created today(created a bunch of new models ;-) ) where only for one attribute.

[slavcodev]

OK, I agree. But I propose move conversion in Model::createValidators

[coveralls]

Coverage remained the same when pulling ecc557e on slavcodev:only-arrays-in-rules into 6066c29 on yiisoft:master.

[coveralls]

Coverage remained the same when pulling cbca145 on slavcodev:only-arrays-in-rules into 6066c29 on yiisoft:master.

[coveralls]

Coverage remained the same when pulling 9bf7f79 on slavcodev:only-arrays-in-rules into 6066c29 on yiisoft:master.

[coveralls]

Coverage remained the same when pulling 3ff8f10 on slavcodev:only-arrays-in-rules into 6066c29 on yiisoft:master.

[coveralls]

Coverage decreased (-0.43%) when pulling 2adcd16 on slavcodev:only-arrays-in-rules into 6066c29 on yiisoft:master.

[qiangxue]

As discussed earlier, for single attribute, we prefer to use a string rather than an array. Could you please fix this?

[slavcodev]

Fixed.

[samdark]

I'm for taking this change. With 5.4 array syntax it looks much better than strings.

[coveralls]

Coverage decreased (-0.09%) when pulling f57b353 on slavcodev:only-arrays-in-rules into 6066c29 on yiisoft:master.

[qiangxue]

Thank you very much!