Moved authManager from base to web application

[samdark]

It's rarely used in apps other than web and can be set in config if needed.

[klimov-paul]

Disagreed.
It could be a situation, when I need RBAC checks even in console application. Indeed it will unlikely check current user permissions, but it can be used to check permissions for the particular user in the database.

// Some cron script:
$users = User::find()->all();
foreach ($users as $user) {
    if (Yii::$app->authManager->checkAccess($user->id, 'adminNotification')) {
        Yii::$app->mail->... ->send();
    }
}

[coveralls]

Coverage remained the same when pulling 89aa62f on moved-auth-to-web into 0eaafd7 on master.

[ponikrf]

Am... if count users over 9000? superfast realization...
imho you went on the wrong side
And... you can load this component late...

Sorry for my english

[klimov-paul]

if count users over 9000?

Need to use DataProvider with pagination then. This is a concept example after all.

you can load this component late

I can tell same thing about almost any application component. Following this philosophy we should remove “authManager” even from yii\web\Application, because it could be a web application, which will not use RBAC.

RBAC is not web-specific feature – it is a basic thing, which can be used anywhere, so it should be kept in the base application.

[samdark]

Yes, it can be used in console but it's rare in practice. Nothing prevents you from adding it later via config.

[ponikrf]

Following your logic, anything can be used anywhere.

RBAC is not web-specific feature – it is a basic thing, which can be used anywhere, so it should be kept in the >base application.

Basic application can not exist without RBAC? seriously?

[qiangxue]

I think it should remain in base application. It's like urlManager. You usually don't directly use it in console, but you often need to work with it (such as maintaining RBAC, generating URLs, etc.)

[samdark]

Makes sense.

[ponikrf]

If you add this method to \yii\web\Application and \yii\console\Application and remove from \yii\base\application?
You do not like this practice?

[cebe]

@ponikrf it would be duplicating code that can be done in one place. so not a good solution.