Eliminating $_GET array #1207
Merged
Eliminating $_GET array #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Overall code change is OK but tests are failing. |
Contributor
Author
|
@samdark What problem you have? |
Member
ghost
assigned
cebe
added a commit
that referenced
this pull request
Nov 16, 2013
cebe
added a commit
that referenced
this pull request
Nov 16, 2013
Member
|
Thanks! Adjusted it to work also when request is not web. |
Contributor
Author
$params = (Yii::$app->request instanceof Request) ? Yii::$app->request->get : [];Must be Yii::$app->request->get()! |
Member
|
Thanks, has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the best practice to use common wraper for defining the get-parameters.