Language meta information should reflect actual application language (instead of hardcoded EN) #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Fix is not exactly correct. For the language dialects it would produce invalid HTML. str_replace('_', '-', \Yii::app()->language); |
Contributor
Author
|
Okay, I changed the commits. I must confess it doesn't look very elegant. Why can't we also use languages with dashes internally? |
Contributor
|
I would rather "hide" this logic |
Member
Member
|
Never mind. intl works with both dash and underscore. Dash separator is more popular. |
Member
|
Yeah, I've just verified that. |
qiansen1386
pushed a commit
to qiansen1386/yii2
that referenced
this pull request
Mar 9, 2014
…ge and country in locale id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the layout of the basic and advanced app templates has English hardcoded as language:
<html lang="EN">Since language is a dynamic attribute in the application config. Based on Paul's suggestion, I propose to use this: