Skip to content

Renamed DetailView attribute "type" to "format" #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2013
Merged

Renamed DetailView attribute "type" to "format" #1277

merged 1 commit into from
Nov 21, 2013

Conversation

@cebe
Copy link
Member

@cebe cebe commented Nov 21, 2013

for consistency with GridViews DataColumn, where the same property is
also named format.

@cebe
Renamed DetailView attribute type to format
c7ef701 
for consistency with GridViews DataColumn where the same property is
also named format
@coveralls
Copy link

coveralls commented Nov 21, 2013

Coverage Status

Coverage decreased (-0.03%) when pulling c7ef701 on cebe:grid-detail-view-consistency into f3ab5d9 on yiisoft:master.

qiangxue added a commit that referenced this pull request Nov 21, 2013
@qiangxue
Merge pull request #1277 from cebe/grid-detail-view-consistency
e3784e4 
Renamed DetailView attribute "type" to "format"
@qiangxue qiangxue merged commit e3784e4 into yiisoft:master Nov 21, 2013
@qiangxue
Copy link
Member

qiangxue commented Nov 21, 2013

Thanks!

@cebe cebe deleted the grid-detail-view-consistency branch November 21, 2013 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0 Alpha

Development

Successfully merging this pull request may close these issues.

3 participants

@cebe @coveralls @qiangxue