Coveralls.io travis settings and phpunit #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdark
added a commit
that referenced
this pull request
Jul 29, 2013
Coveralls.io travis settings and phpunit
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #664 (comment) (comment1) and #664 (comment) (comment 2)
Steps to be taken before merge:
I have not added the badge yet, as 57% coverage seems a bit low, so this should be investigated/fixed first before advertising with coverage ;)
The list of ignored files in phpunit.xml.dist should be adjusted, as more tests are added (HelperBase classes are still in the report, coverage of empty classes seemed to vary based on travis-php-version, so I ignored them for now, however last build showed them just fine, issue might be fixed)