[WIP] Validator tests

[suralc]

Begun to write some tests for the validators.

I'll add additional tests in the comming days. I just opened this PR, that no duplicate work is made.

[coveralls]

Coverage increased (+0%) when pulling ec1dfea on suralc:add-tests into 1e0decf on yiisoft:master.

[qiangxue]

Thank you for adding test cases. Your effort is greatly appreciated!

Why adding @codeCoverageIgnore to clientValidateAttribute()? I think we still need to test them, somehow, in future.

[suralc]

Yes, we need to, but I couldn't think of a clean solution to do this, without tapping into view or asset management to deep for now, I'll focus on the other tests and remove that tag later.

[coveralls]

Coverage increased (+0%) when pulling 777ff79 on suralc:add-tests into 1e0decf on yiisoft:master.

[coveralls]

Changes Unknown when pulling 467d88f on suralc:add-tests into * on yiisoft:master*.

[coveralls]

Changes Unknown when pulling 467d88f on suralc:add-tests into * on yiisoft:master*.

[coveralls]

Changes Unknown when pulling f7bb54b on suralc:add-tests into * on yiisoft:master*.

[suralc]

Sorry for the long delay, I'll add the remaining tests asap (this week)

[qiangxue]

No problem. Your contribution is always welcome. Thank you. 👍

[suralc]

@qiangxue
Just a question:

If a validator is not associated with any attributes it will raise a php-error if Validator::validate($object) is called. Situation may never occur in user-code as there will be an exception earlier in Model::createValidators(). However, if a validator is created by hand and one use it via Validator::validate($obj) he might run into this undeclarative error:

1) yiiunit\framework\validators\ValidatorTest::testValidateWithEmptyAttributes
Invalid argument(null) supplied for foreach()

D:\dev\www\vhosts\yii2\framework\yii\validators\Validator.php:180

Should this stay as is, or raise an exception?

[qiangxue]

Fixed in 1ca215d

[cebe]

Should this stay as is, or raise an exception?

I think Validator::$attributes should be empty array by default

[cebe]

@qiangxue :-D great, same thought in same second ;)

[suralc]

Would be the most obvious ;) Thanks

[coveralls]

Coverage increased (+0%) when pulling 02c92fe on suralc:add-tests into 90ddea1 on yiisoft:master.

[coveralls]

Coverage increased (+0%) when pulling 0133069 on suralc:add-tests into 6e32fae on yiisoft:master.

[coveralls]

Coverage remained the same when pulling 4727049c3a364b18a590a7ee8e3edc20868207fe on suralc:add-tests into 6e32fae on yiisoft:master.

[coveralls]

Coverage increased (+0%) when pulling 4ffffec328931f85ad2b07c8a5fe794081869fcb on suralc:add-tests into 6e32fae on yiisoft:master.

[coveralls]

Coverage remained the same when pulling 5c8927a on suralc:add-tests into 9a9a9c0 on yiisoft:master.

[coveralls]

Coverage remained the same when pulling 5c8927a on suralc:add-tests into 9a9a9c0 on yiisoft:master.

[coveralls]

Coverage remained the same when pulling 3b07e4a on suralc:add-tests into 9a9a9c0 on yiisoft:master.

[suralc]

Not sure about naming, or if this is to be avoided.

[qiangxue]

Seems we don't need it. You can assign ActiveRecord::$db with $this->getConnection(), like ActiveRecordTest.

[coveralls]

Coverage increased (+2.73%) when pulling c336c7b2b83234a2480cffd0135da3de711f2bc3 on suralc:add-tests into 9a9a9c0 on yiisoft:master.

[coveralls]

Coverage remained the same when pulling 06682d0 on suralc:add-tests into f3cd755 on yiisoft:master.

[cebe]

@suralc thanks for the great work in here. can you tell whats missing?

[samdark]

Updated and merged. @suralc thank you very much!