A simple patch to get AspectMock and Go Aop working with Yii2 #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very tiny patch that changes nothing in code logic, but is required to get [AspectMock](https://github.com/Codeception/AspectMock) and Go Aop working with Yii2. Go Aop is processing all `include` and `require` directives, replacing them with its filters. Unfortunately it doesn't play well with one-liners. So I had to break the code into few lines to get that working. I was trying to fix this issue in [Go Aop](goaop/framework#78) but looks like, the only option is to fix that in Yii2. AspectMock can dramaticly improve unit testing in Yii2, and I plan to do a blogpost with tutorial about it.
Contributor
|
The modification is minimal, I agree to include it if that is going to make it work with those amazing libraries. |
samdark
added a commit
that referenced
this pull request
Jul 31, 2013
A simple patch to get AspectMock and Go Aop working with Yii2
Member
|
Merged. |
|
Wow, it was fast ) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very tiny patch that changes nothing in code logic, but is required to get AspectMock and Go Aop working with Yii2.
Go Aop is processing all
includeandrequiredirectives, replacing them with its filters. Unfortunately it doesn't play well with one-liners. So I had to break the code into few lines to get that working.I was trying to fix this issue in Go Aop but looks like, the only option is to fix that in Yii2.
AspectMock can dramaticly improve unit testing in Yii2, and I plan to do a blogpost with tutorial about it.