Fix function argument #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```php normalizeItems($items, &$active) ``` Qiang use ```php $items[$i]['items'] = $this->normalizeItems($item['items'], $route, $hasActiveChild); ``` So $hasActiveChild not assign value and parent item not set activated Plz, review and approval Thanks
|
Changes Unknown when pulling 23dfd13 on yiidevelop:patch-3 into * on yiisoft:master*. |
Contributor
Author
|
@coveralls I do not understand your saying |
Contributor
|
@yiidevelop coveralls is a bot. It just had issues updating code-coverage for your pull-request(don't know why, but I assume this can be ignored for now.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qiang use
So $hasActiveChild not assign value and parent item not set activated
Plz, review and approval
Thanks