Skip to content

Conversation

@yiidevelop
Copy link
Contributor

Please review and approval

Thanks

Please review and approval

Thanks
@ghost ghost assigned qiangxue Aug 21, 2013
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.11%) when pulling a0117d6 on yiidevelop:patch-1 into 2a152cb on yiisoft:master.

@qiangxue
Copy link
Member

won't accept this because the default implementation is more like a placeholder. We don't want it to be dependent on the tablePrefix property.

@qiangxue qiangxue closed this Aug 21, 2013
@yiidevelop
Copy link
Contributor Author

Yes, so when we use tablePrefix then frequent must use extends method [[tableName()]]:

class MyActiveRecord extends yii\db\ActiveRecord
{
.....
    public static function tableName()
    {
        return '{{%my_active_record}}';
    }
.....

I feel this is a waste, I know it's been fully utilized in gii

@cebe
Copy link
Member

cebe commented Aug 22, 2013

Beening explicit about tablename by overriding it is also faster than relying on default implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants