add Html::cssClassExist and fix add duplicated class #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
I propose to rename it to hasCssClass. Also I think explode can be used instead of regexp.
Or at least PREG_SPLIT_NO_EMPTY instead of extra trim.
Member
|
Change itself is valid. Please address comments and I'll merge it. |
Contributor
Author
|
I don't known use about github to change which your say, Please do it yourself :) Now, i must re-edit file and create new pull? |
Member
|
No. You just commit your changes to the same branch and that's it. |
yiidevelop
added a commit
to yiidevelop/yii2
that referenced
this pull request
Aug 26, 2013
Please, review and approval
Contributor
Author
yiidevelop
added a commit
to yiidevelop/yii2
that referenced
this pull request
Aug 26, 2013
So sorry )
yiidevelop
added a commit
to yiidevelop/yii2
that referenced
this pull request
Aug 26, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.