Remove pandas dependency from meldataset.py#362
Open
netlinux-ai wants to merge 1 commit intoyl4579:mainfrom
Open
Remove pandas dependency from meldataset.py#362netlinux-ai wants to merge 1 commit intoyl4579:mainfrom
netlinux-ai wants to merge 1 commit intoyl4579:mainfrom
Conversation
The only use of pandas was a single speaker_id filter when sampling a reference clip; replaced with a list comprehension and random.choice. Drops pandas (and its transitive pyarrow dep) from the dependency graph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
meldataset.pyimportspandasand uses it for one operation: filteringdata_listbyspeaker_idwhen sampling a reference clip. Pandas is otherwise unused.This adds a heavyweight dependency for a single filter call. It also pulls in pandas's transitive
pyarrowdependency, which is the source of compatibility friction:pip installweight goes up by ~80 MB for one filter line.Fix
Replace the single pandas usage with a list comprehension +
random.choice:Drops both
pandasandpyarrowfrom the dependency graph. Unusedself.dfmember is removed; unusedimport pandas as pdis removed.Tested with