feat: propagate HCL inline comments on attributes to YAML output#10
Merged
jccguimaraes merged 2 commits intomainfrom Apr 10, 2026
Merged
feat: propagate HCL inline comments on attributes to YAML output#10jccguimaraes merged 2 commits intomainfrom
jccguimaraes merged 2 commits intomainfrom
Conversation
Introduces an `annotated` wrapper type that threads trailing `# comments` from HCL attributes through the `map[string]any` pipeline. `toYAMLNode` unwraps it and attaches the comment as a `LineComment` on the YAML node, so any attribute-level comment in HCL appears inline in the generated YAML. Validators that type-assert map values use `unwrapAnnotatedMap` to strip the wrapper before checking. The permissions-specific `parsePermissionsBlock` and `permissionsMapNode` helpers are removed — the general mechanism covers that case automatically.
Go test coverage: 65.1% for commit e6bb071
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces an
annotatedwrapper type that threads trailing# commentsfrom HCL attributes through themap[string]anypipeline.toYAMLNodeunwraps it and attaches the comment as aLineCommenton the YAML node, so any attribute-level comment in HCL appears inline in the generated YAML.Validators that type-assert map values use
unwrapAnnotatedMapto strip the wrapper before checking. The permissions-specificparsePermissionsBlockandpermissionsMapNodehelpers are removed — the general mechanism covers that case automatically.