Skip to content

[codex] Fix Cmd+Enter submit when idle#11

Merged
SawyerHood merged 1 commit into
mainfrom
bb/cmd-enter-normal-submit-when-idle-thr_4w7a9udqcc
May 14, 2026
Merged

[codex] Fix Cmd+Enter submit when idle#11
SawyerHood merged 1 commit into
mainfrom
bb/cmd-enter-normal-submit-when-idle-thr_4w7a9udqcc

Conversation

@SawyerHood

Copy link
Copy Markdown
Collaborator

Summary

  • Wire the follow-up prompt modifier shortcut only when steer submit is actually available.
  • Let Cmd+Enter fall through to the normal prompt submit path on idle/non-working threads.
  • Add focused coverage for active steer behavior and idle normal-submit behavior with queued/current drafts.

Validation

  • PATH="/Users/sawyerhood/Library/Caches/pnpm/dlx/mgdbhd5zwcpibuaobycjdzyaga/19e28e4c4fd-bb5d/node_modules/.pnpm/node@22.12.0/node_modules/node/bin:$PATH" pnpm exec turbo run test --filter=@bb/app -- src/components/promptbox/FollowUpPromptBox.test.tsx src/views/thread-detail/ThreadDetailPromptArea.test.tsx
  • PATH="/Users/sawyerhood/Library/Caches/pnpm/dlx/mgdbhd5zwcpibuaobycjdzyaga/19e28e4c4fd-bb5d/node_modules/.pnpm/node@22.12.0/node_modules/node/bin:$PATH" pnpm exec turbo run typecheck --filter=@bb/app

Note: the ambient shell is on Node 25.3.0, which breaks jsdom localStorage before tests load. Validation was run with Node 22.12.0 from .nvmrc first in PATH.

@SawyerHood SawyerHood marked this pull request as ready for review May 14, 2026 23:55
@SawyerHood SawyerHood merged commit 19d678e into main May 14, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant