refactor: settings store の 11 setter を makeSetter factory で集約 (#271)#273
Merged
Conversation
src/stores/settings.ts で 11 個の setter (setShowLineNumbers /
setFontSize / setAutoSaveDelay / setHighlightActiveLine / setFontFamily /
setTrimTrailingWhitespace / setShowLinkCards / setScratchpadVolatile /
setAutoUpdateCheck / setFileTreeShowHidden / setFileTreeExcludePatterns)
が全て同一 3 行 pattern (void saveXxx(val) + set({key: val})) だったため、
create() 内 closure factory `makeSetter<K extends keyof SettingsValues>` を
定義し 11 setter を 1 行呼び出しに置換。
- generic factory で key と value 型の対応を静的保証 (tsc で wrong-variable
copy-paste を検出可能)
- scope は file-private (create() 内 closure)
- 挙動同一 (void save() → set({key: value}) の順序と semantics 維持)
- vitest 2230 pass / 2 skipped, settings.test.ts 14 pass, biome/typecheck clean
Closes #271
ymnao
added a commit
that referenced
this pull request
Jul 5, 2026
- package.json の version を 0.6.0 → 0.7.0 に bump - CHANGELOG.md に v0.7.0 エントリを追加 (#243 〜 #280) - Fixed: FileTree scroll regression (#276)、electron e2e launch teardown timeout 拡大 (#247) - Internal: #209 3 項目 (drift-lock 系 refactor #278/#279/#280)、settings setter 集約 (#273 → #277)、search/workspace/backlink 系 helper 抽出 15 件 - Dependencies: electron 43.0.0 / p-limit 7.3.0 major bump (#275)、Dependabot 7 件 combine (#274)、pnpm-workspace.yaml overrides で @codemirror dual copy を恒久防止 Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
src/stores/settings.tsに定義された 11 個の setter (setShowLineNumbers/setFontSize/setAutoSaveDelay/setHighlightActiveLine/setFontFamily/setTrimTrailingWhitespace/setShowLinkCards/setScratchpadVolatile/setAutoUpdateCheck/setFileTreeShowHidden/setFileTreeExcludePatterns) が全て同一 3 行 pattern (void saveXxx(val); set({key: val});) だったため、create()内 closure factorymakeSetter<K extends keyof SettingsValues>を定義し 11 setter を 1 行呼び出しに置換。関連 Issue
Closes #271
移行 Stage
Stage 分類外（Electron 化完了後の内部品質改善）。
変更内容
src/stores/settings.tsにcreate()内 closure factorymakeSetter<K extends keyof SettingsValues>(key, save)を追加動作確認
src/stores/settings.test.ts14 pass[]（correctness / cleanup / conventions 違反なし）検討事項
/simplifyの Reuse / Altitude reviewer が「makeSetterをsrc/lib/store-helpers.tsに hoist してgit-sync.tsの 7 setter と共通化」を指摘（HANDOFF 49 ★「次 PR で 2 箇所目が発生したら helper 化」基準成立）。本 PR は user 明示採択 scope（settings.ts1 file）から逸脱するため対応せず、follow-up issue #272 を起票済（次 PR でmakePersistedSetter<TValues, K>を generic hoist +git-sync.tsのsetCommitMessage用normalize?optional transform を追加予定）。スクリーンショット
UI 変更なし。