feat: update ダイアログに Homebrew upgrade 手順を追加#296
Merged
Conversation
- `useUpdateCheck.ts` の `formatUpdateDescription()` に "Homebrew でインストールした場合は `brew upgrade --cask scripta` を実行してください。" を追記 - 現状ダイアログは GitHub Releases DL しか案内していないため、Cask 経由でインストールしたユーザに brew upgrade の実行手段を明示 - Dialog 共通コンポーネントの interface は変更なし (description string への 1 文追加のみ) - Homebrew Cask 対応 (#282) Phase 3 の renderer 側導線
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
update ダイアログの description に「Homebrew でインストールした場合は
brew upgrade --cask scriptaを実行してください。」の 1 文を追加。関連 Issue
Issue #282 (Homebrew Cask 配布) の Phase 3 renderer 側導線対応。close ではなく参照 (Phase 1 tap repo 作成 / Phase 2 workflow は別対応)。
移行 Stage
変更内容
src/hooks/useUpdateCheck.ts:10のformatUpdateDescription()に`brew upgrade --cask scripta`の 1 文を追記src/components/common/Dialog.tsx) の interface は変更なし (description string への 1 文追加のみ)動作確認
src/hooks/useUpdateCheck.test.ts) の description assertion (toContain("v1.0.0")) は破壊せず PASSスクリーンショット
なし (テキスト copy 変更のみ、Dialog 表示幅内で自然にラップされる)
検証エビデンス
リスク分類
tier: high — reason:
agent-config: src/hooks/useUpdateCheck.ts(classify-risk.sh の pattern が hook パスに false-hit、実質は renderer の string 1 文追加 +1 -1)実行した検証
./node_modules/.bin/tsc -p tsconfig.web.json --noEmit./node_modules/.bin/tsc -p tsconfig.node.json --noEmit./node_modules/.bin/tsc -p tsconfig.e2e.json --noEmit./node_modules/.bin/biome check./node_modules/.bin/vitest runbash ~/.claude/skills/codex-review/scripts/run-review.sh shell-seniorbash ~/.claude/skills/codex-review/scripts/run-review.sh securitybash ~/.claude/skills/codex-review/scripts/run-review.sh qa-fixtureレビュー指摘と対応
UNRESOLVED findings: 0 件