Align resolution data with other hosts in Ayon #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonyuet
added
the
type: enhancement
moonyuet
requested review from
BigRoy,
LiborBatek,
antirotor and
philippe-ynput
BigRoy
approved these changes
Apr 14, 2025
Contributor
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Didn't test, but changes make sense.
LiborBatek
approved these changes
Apr 17, 2025
Member
LiborBatek
left a comment
LiborBatek
left a comment
There was a problem hiding this comment.
I have followed testing steps and been able to produce review without any issues whatsoever...
P.S. there is no mention about missing frames and testing of such occasion tho...how about that??
Member
Author
We can create a separate issue for that. |
moonyuet
deleted the
enhancement/align-resolution-width-height-with-other-hosts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR is to add resolution data into instance data to align with the resolution data in other hosts.
Instead of
review_heightandreview_width, we would useresolutionHeightandresolutionWidthinstead.Links to ynput/ayon-core#1234
Additional review information
Try along with the linked PR above and this PR would ensure publishing review in Max would not error out
Extract Reviewwhen handling missing frame set togenerate blank frame(related setting:ayon+settings://core/publish/ExtractReview/profiles/0/outputs/1/fill_missing_frames).Testing notes: