Skip to content

Conversation

@moonyuet
Copy link
Member

@moonyuet moonyuet commented May 8, 2025

Changelog Description

This PR is to support to set up the multipass when creating render instance

Additional review information

  • The multipass option currently only works for Redshift Renderer
  • Test with manually turning on/off the seperate AOV files and publish after creating instances

Testing notes:

  1. Create Render Instance with/without multipass by toggling ayon+settings://max/RenderSettings/multipass
  2. Publish

@moonyuet moonyuet requested review from LiborBatek and antirotor May 8, 2025 05:45
@moonyuet moonyuet self-assigned this May 8, 2025
@moonyuet moonyuet added the type: enhancement Improvement of existing functionality or minor addition label May 8, 2025
@moonyuet moonyuet requested a review from MustafaJafar May 8, 2025 05:46
@MustafaJafar MustafaJafar linked an issue May 8, 2025 that may be closed by this pull request
1 task
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even tho Im still fighting with my PC configuration (Rshift finally installed but DL refuses to work still) I can tell there is no change from ayon-3dsmax propagated when checking render settings after creation of render publish instance,

Do I get it correctly that the Ayon addon settings MultiPass refers to Separate AOVs and not that MultiPart option as it is something different speaking of EXR format...

Could you confirm these green ones refer to the same thing?
Screenshot 2025-07-07 175320

Screenshot 2025-07-07 175132

As now I can tell they are not correctly propagated and differ??

P.S. I will update the testing when having DL fully functional on my PC and keep you updated.

@LiborBatek
Copy link
Member

and if so and they should be standing for the same setting/feature... you should change the terminology so they reads the same...

e.g. instead of Multipass using Separate AOVs etc.

@moonyuet
Copy link
Member Author

moonyuet commented Jul 7, 2025

and if so and they should be standing for the same setting/feature... you should change the terminology so they reads the same...

e.g. instead of Multipass using Separate AOVs etc.

Thank you!
It should be separating the exr too if there is multipass setting..

@LiborBatek LiborBatek self-requested a review July 8, 2025 08:52
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I havent spotted any issues when that setting been enabled or disabled...

been tested with Separate AOVs enabled and also disabled...both finnished succesfully on DL and properly integrated. Havent spotted any discrepancies at all.

I really do not have idea what this PR is about and the Multipass setting do... but I have followed the testing steps and succeeded.

@moonyuet
Copy link
Member Author

moonyuet commented Jul 8, 2025

I really do not have idea what this PR is about and the Multipass setting do... but I have followed the testing steps and succeeded.

We can create the issue for multipass and discuss how to work on this as the collector needs to be refactored to support the multipass option within (Redshift), although it's weird to have two mutlipass settings(separateAovFiles, multipass) in Redshift.

@moonyuet moonyuet merged commit 81f7c8e into develop Jul 8, 2025
1 check passed
@moonyuet moonyuet deleted the enhancement/include_mutlipass_setting_during_creating_render_product branch July 8, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multipass setting is not used

3 participants