Make sure render setting updated after repairing with validate renderpass #47
Conversation
moonyuet
added
type: enhancement
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Code changes seem fine. I did have two comments I was a bit confused about - so please check those just to be sure.
|
By the way, how does this PR fix #28 ? |
it is already fixed if speaking of the renaming of the validator. |
In that case - close the issue and mention where it's fixed and unlink it from this PR? |
|
@BigRoy would you mind check again? |
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
LGTM - minor comment on whether a docstring is needed, but other than that code seems fine to me.
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
…og.update() and remove check on scenedialog is open
…d in render_output()
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Didn't test - but changes make sense.
|
Tested in my side, the issues of repairing action in validate renderpass has been fixed. |
Changelog Description
This PR is to ensure render setting updated after repairing with validate renderpass(including hardcoded code).
This also ensure the render element created with Vray Renderer to be fixed correctly too.
Fix #43, #28, #42
Additional review information
n/a
Testing notes: