Skip to content

Conversation

@antirotor
Copy link
Member

@antirotor antirotor commented Dec 10, 2025

Changelog Description

This is adding product base types support to existing creators. In this stage, it only mimics the product types. This has to be done in all DCC before further changes can be done in https://github.com/ynput/ayon-core to finalize the support.

Additional review information

Additional PRs should check/address the usage of product_type as family - plugins shouldn't rely on having product type as family because if/when this is customized, workflow could stop work or behave unpredicable.

Testing notes:

Everything should work as before.

@antirotor antirotor self-assigned this Dec 10, 2025
@antirotor antirotor added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Dec 10, 2025
@antirotor antirotor linked an issue Dec 10, 2025 that may be closed by this pull request
@kalisp
Copy link
Member

kalisp commented Dec 12, 2025

Why this PR only adds product_base_type when Photoshop PR updates get_product_name with them too?

Should this be a responsibility of addon owner to update it later? (Fine by me.)

@iLLiCiTiT
Copy link
Member

Why this PR only adds product_base_type when Photoshop PR updates get_product_name with them too?

I guess it is because Photoshop is calling the get_product_name function directly, whereas AE don't touch it and use defaults from ayon-core?

@antirotor
Copy link
Member Author

Exactly. These PRs are adding product_base_type and changing usage of get_product_type() if it is used directly (and also changing the use of newer signature if this is the case)

@iLLiCiTiT iLLiCiTiT merged commit db5f25f into develop Dec 15, 2025
7 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancemen/52-product-base-types-add-support-to-creators branch December 15, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🏛️Product base types: add support to creators

4 participants