Skip to content

fix: reviewable files with incorrect unsupported characters failing#1908

Merged
Innders merged 1 commit intodevelopfrom
1907-YN-0638-Reviewables-some-filenames-cause-error
Apr 7, 2026
Merged

fix: reviewable files with incorrect unsupported characters failing#1908
Innders merged 1 commit intodevelopfrom
1907-YN-0638-Reviewables-some-filenames-cause-error

Conversation

@Innders
Copy link
Copy Markdown
Member

@Innders Innders commented Apr 7, 2026

This pull request improves the robustness of file uploads in useReviewablesUpload by standardizing how file names are processed. The main change is the introduction of a parseFilename function to sanitize file names by removing non-ISO-8859-1 characters (such as emojis and special spaces) and ensuring every file has a usable name. This function is then used consistently throughout the upload process to avoid mismatches and errors.

@Innders Innders self-assigned this Apr 7, 2026
@Innders Innders added the type: bug Something isn't working label Apr 7, 2026
@Innders Innders linked an issue Apr 7, 2026 that may be closed by this pull request
@Innders Innders merged commit be34613 into develop Apr 7, 2026
2 checks passed
@Innders Innders deleted the 1907-YN-0638-Reviewables-some-filenames-cause-error branch April 7, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

YN-0638: Reviewables: some filenames cause error

1 participant