Skip to content

Conversation

@jakubjezek001
Copy link
Member

Changelog description

Validates colorspace settings against available options, ensuring correct configuration.

Removes deprecated code related to project colorspace modification via hrox file manipulation.

Updates the widget setting logic to handle errors and avoid setting invalid values.

Additional info

During new ocio v2 aces 1.3 config testing I had found out that our set project colorspace action was failing. This is quick fix

Testing notes

  1. Set any other value into ayon+settings://hiero/imageio/workfile/workingSpace > compositing_log
  2. value should be set to the project root settings and you can find them at hiero menu/Project/Project Settings/Colorspace Management/Working space

Validates colorspace settings against available options, ensuring correct configuration.

Removes deprecated code related to project colorspace modification via hrox file manipulation.

Updates the widget setting logic to handle errors and avoid setting invalid values.
@jakubjezek001 jakubjezek001 self-assigned this May 9, 2025
@jakubjezek001 jakubjezek001 requested review from MilaKudr and moonyuet May 9, 2025 14:19
@jakubjezek001 jakubjezek001 added the type: bug Something isn't working label May 9, 2025
@jakubjezek001 jakubjezek001 requested a review from iLLiCiTiT May 9, 2025 14:20
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested with hiero 14.0v4
The setting works for setting up the working colorspace and any default color-transform relevant attribute.
But the setting for OCIO configuration is not correctly set.(I didn't enable the OCIO config in core addon just FYI, and I just only enabled the hiero OCIO color config. It works nicely when the OCIO config in core addon enabled). Is it expected behavior? We can solve this in a separate issue instead(it's good to go for setting up working space attributes).

image

@MustafaJafar
Copy link
Member

Since we have this PR, could we tweak settings to be ub the same order as in preferences. (I can push it to this PR if you'd like ^^, I'll only update some labels and re-arrange them, so it won't affect any thing.)
It's not necessary though.

image

@jakubjezek001
Copy link
Member Author

Since we have this PR, could we tweak settings to be ub the same order as in preferences. (I can push it to this PR if you'd like ^^, I'll only update some labels and re-arrange them, so it won't affect any thing.) It's not necessary though.

yeah go ahead @MustafaJafar

@jakubjezek001
Copy link
Member Author

I have tested with hiero 14.0v4 The setting works for setting up the working colorspace and any default color-transform relevant attribute. But the setting for OCIO configuration is not correctly set.(I didn't enable the OCIO config in core addon just FYI, and I just only enabled the hiero OCIO color config. It works nicely when the OCIO config in core addon enabled). Is it expected behavior? We can solve this in a separate issue instead(it's good to go for setting up working space attributes).

Yeah it seems like a bug and I will look into it within the scope of this PR. Thanks for the catch tho.

@MustafaJafar
Copy link
Member

yeah go ahead @MustafaJafar

Thank you, I've pushed e46cd7e and also updated the Configure Hiero Addon docs accordingly .

@jakubjezek001 jakubjezek001 requested a review from moonyuet June 5, 2025 08:50
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to implement compositing_log as workingSpace, the attribute is set as expeced.
image

@jakubjezek001 jakubjezek001 merged commit b48ca40 into develop Jun 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants