-
Notifications
You must be signed in to change notification settings - Fork 8
Improves colorspace setting validation #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves colorspace setting validation #59
Conversation
Validates colorspace settings against available options, ensuring correct configuration. Removes deprecated code related to project colorspace modification via hrox file manipulation. Updates the widget setting logic to handle errors and avoid setting invalid values.
moonyuet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested with hiero 14.0v4
The setting works for setting up the working colorspace and any default color-transform relevant attribute.
But the setting for OCIO configuration is not correctly set.(I didn't enable the OCIO config in core addon just FYI, and I just only enabled the hiero OCIO color config. It works nicely when the OCIO config in core addon enabled). Is it expected behavior? We can solve this in a separate issue instead(it's good to go for setting up working space attributes).
yeah go ahead @MustafaJafar |
Yeah it seems like a bug and I will look into it within the scope of this PR. Thanks for the catch tho. |
Thank you, I've pushed e46cd7e and also updated the Configure Hiero Addon docs accordingly . |
moonyuet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.



Changelog description
Validates colorspace settings against available options, ensuring correct configuration.
Removes deprecated code related to project colorspace modification via hrox file manipulation.
Updates the widget setting logic to handle errors and avoid setting invalid values.
Additional info
During new ocio v2 aces 1.3 config testing I had found out that our set project colorspace action was failing. This is quick fix
Testing notes
ayon+settings://hiero/imageio/workfile/workingSpace> compositing_loghiero menu/Project/Project Settings/Colorspace Management/Working space