Skip to content

Settings: Refactor conditionalEnum -> conditional_enum #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iLLiCiTiT merged 1 commit into from
Jun 25, 2025
Merged

Settings: Refactor conditionalEnum -> conditional_enum #70

iLLiCiTiT merged 1 commit into from
Jun 25, 2025

Conversation

@BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jun 24, 2025

Changelog Description

Refactor conditionalEnum -> conditional_enum

Additional review information

Avoid logs like:

DEBUG settings.settings_field | Deprecated argument: conditionalEnum

Testing notes:

  1. Check whether settings are still ok

@BigRoy
Refactor conditionalEnum -> conditional_enum
6ba2c19 
Avoid logs like:
```
DEBUG settings.settings_field | Deprecated argument: conditionalEnum
```
@BigRoy BigRoy requested a review from jakubjezek001 June 24, 2025 21:02
@BigRoy BigRoy self-assigned this Jun 24, 2025
@BigRoy BigRoy added type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) community Issues and PRs coming from the community members labels Jun 24, 2025
@iLLiCiTiT iLLiCiTiT added type: enhancement Improvement of existing functionality or minor addition and removed type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) labels Jun 25, 2025
@iLLiCiTiT iLLiCiTiT merged commit 5f902ce into develop Jun 25, 2025
8 checks passed
@iLLiCiTiT iLLiCiTiT deleted the chore/settings_fix_deprecated_conditionalEnum branch June 25, 2025 09:08
@iLLiCiTiT iLLiCiTiT mentioned this pull request Jun 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

Assignees

@BigRoy BigRoy

Labels

community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BigRoy @iLLiCiTiT