-
Notifications
You must be signed in to change notification settings - Fork 8
Re-introduce comments from tags #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the comment tag collection functionality from OpenPype to AYON, enabling the collection of comments from tags on track items and their sources in Hiero.
- Adds type annotations and imports for better code clarity
- Updates the plugin to use direct tag object methods instead of dictionary access
- Modernizes string formatting to use f-strings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@antirotor I tried those changes and I could properly see the comments being detected and added to the Is it to benefit from Because, if so I believe more work in
|
- Collects comments from tags with name 'comment'. - Extends collected comments to instance data. - Includes existing comments if they are present. - Joins comments with a separator " | ".
jakubjezek001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rdelillo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I realized I wasn't looking at the proper place.
Works as expected on my side. Good job !


Changelog Description
Collecting comment tag was possible in OpenPype. This is migrating the plugin to be used in AYON too.
Testing notes: