Skip to content

Conversation

@antirotor
Copy link
Member

Changelog Description

Collecting comment tag was possible in OpenPype. This is migrating the plugin to be used in AYON too.

Testing notes:

  1. Add comment tag to clips
  2. Publish

@antirotor antirotor self-assigned this Sep 12, 2025
@antirotor antirotor added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Sep 12, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the comment tag collection functionality from OpenPype to AYON, enabling the collection of comments from tags on track items and their sources in Hiero.

  • Adds type annotations and imports for better code clarity
  • Updates the plugin to use direct tag object methods instead of dictionary access
  • Modernizes string formatting to use f-strings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rdelillo
Copy link
Contributor

@antirotor I tried those changes and I could properly see the comments being detected and added to the instance.data.
However I wasn't sure what the end goal would be. I probably missed something.

Is it to benefit from collect_hierarchy and create comments on shot ?

Because, if so I believe more work in ayon-core is required:

  • collect_tag_comments happens on "clip" instances while collect_hierarchy behaves only on "shot"
  • collect_hierarchy is run before collect_tag_comments
  • comments seems to have no effect in extract_hierarchy_to_ayon

- Collects comments from tags with name 'comment'.
- Extends collected comments to instance data.
- Includes existing comments if they are present.
- Joins comments with a separator " | ".
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed it so it supports multiple comment tags. Tho I needed to convert it somehow to single line string, so I have decided to replace each line with |. Let me know if it makes sense or you would rather prefer to have it multilines.

Now it works like this:

Image

and in attributes:

Image

Copy link
Contributor

@rdelillo rdelillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I realized I wasn't looking at the proper place.
Works as expected on my side. Good job !

@jakubjezek001 jakubjezek001 merged commit 02b6cc4 into develop Sep 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants