Skip to content

Conversation

@iLLiCiTiT
Copy link
Member

Description

Uploading is stream based and transfer progress can be captured. Methods uploading thumbnails are using upload_file method now (by allowing **kwargs to method).

@iLLiCiTiT iLLiCiTiT changed the title upload file is passing generator which updates upload progress over time Upload file updates progress over time Nov 29, 2023
@iLLiCiTiT iLLiCiTiT merged commit ab23b29 into develop Nov 29, 2023
@iLLiCiTiT iLLiCiTiT deleted the enhancement/upload-file-is-streamed branch November 29, 2023 16:06
@martastain
Copy link
Member

ayon-backend now uses streaming read for thumbnails as well (originally it was used only for expected large files such as installers). Be aware that streaming may depend on reverse proxy configuration (caddy for example passes streaming requests by default, but nginx IIRC does not and buffers incoming requests)

@iLLiCiTiT
Copy link
Member Author

Happy to change to load file to memory when we hit issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants