Base CRUD functions for entities #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalisp
reviewed
Mar 15, 2024
| status=None, | ||
| active=None, | ||
| thumbnail_id=None, | ||
| folder_id=None, |
Member
There was a problem hiding this comment.
What is use case for passing in identifier of an object I want to create? Is that for creation test data/some imports?
Member
Author
There was a problem hiding this comment.
It's an option in REST api, why not to have it in python api 🙂 . It's heavily used in EntityHub so I can imagine usecase. E.g. recreate project with the same ids?
kalisp
approved these changes
Mar 15, 2024
Member
kalisp
left a comment
kalisp
left a comment
There was a problem hiding this comment.
Other than the question about usefulness of passing ids of created object it looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added simple CRUD operations for folder, task, product, version and representation.
Resolves #35