fix: allow validators to capture external variables#79
Draft
kimjune01 wants to merge 1 commit into
Draft
Conversation
Change Validator and ErrorMessageGenerator from function pointers (fn(&T) -> bool) to boxed closures (Box<dyn Fn + Send + Sync>), enabling validators to capture external state like file lists or shared counters. The validator() method signatures now accept impl Fn, so existing code passing function pointers continues to compile without changes.
Author
|
PR lacks a test exercising the change, so drafting. Please close or take it over. |
Owner
|
@kimjune01 Sorry, I haven’t had a chance to review it in detail yet, but it looks like there are some test cases already. Is my understanding correct that the concern is that the existing tests are insufficient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fn(&str) -> Result<(), String>to acceptFnMut, and box the closure to allow validators that capture and mutate external stateFixes #29
Test plan