Merged
Conversation
- we can have many duplicates of the same violation in the list so we just take the number of unique violations
- when the case is fresh and the AI validation button hasn't been selected we will still have no associated violations. however, we would show that as a postiive thing even though really the checks haven't run so we make the text more neutral. the proper solution would be to check ai_descision
jalsayid
approved these changes
Jul 29, 2025
Collaborator
jalsayid
left a comment
jalsayid
left a comment
There was a problem hiding this comment.
Awesome! and the email service is very quick 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the reviewer page frontend with the validation pipeline.
It also makes the per-guideline delete button real.
It also makes the blueprint selector real.
What to Test
2d-floor-plan.jpg(it's the only one we've tested that works with r2g)violationstable)cases,ai_decisionhas been updatedviolationstable, all instances of that guideline are deleted