Skip to content

Extend possible paths for SettingsPresets#1135

Merged
yonaskolb merged 1 commit intoyonaskolb:masterfrom
SofteqDG:master
Oct 1, 2022
Merged

Extend possible paths for SettingsPresets#1135
yonaskolb merged 1 commit intoyonaskolb:masterfrom
SofteqDG:master

Conversation

@SofteqDG
Copy link
Copy Markdown
Contributor

@SofteqDG SofteqDG commented Oct 5, 2021

  • Search for presets in Bundle.main.resourcesPath dir (if exists)

@yonaskolb
Copy link
Copy Markdown
Owner

Thanks @SofteqDG. Is this for using XcodeGenKit as a dependency, or what is your workflow here?

@SofteqDG
Copy link
Copy Markdown
Contributor Author

SofteqDG commented Nov 3, 2021

Thanks @SofteqDG. Is this for using XcodeGenKit as a dependency, or what is your workflow here?

Hello. Yes, it is for XcodeGenKit as a dependency. I'm using XcodeGenKit as SPM dependency and need to include presets in app bundle to make my app work on other macs.

@SofteqDG
Copy link
Copy Markdown
Contributor Author

@yonaskolb,
Hey. Any thoughts on this change? Can it be merged?

* Search for presets in Bundle.main.resourcesPath dir (if exists)
@SofteqDG SofteqDG closed this by deleting the head repository Sep 29, 2022
@yonaskolb yonaskolb reopened this Oct 1, 2022
Copy link
Copy Markdown
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply on this @SofteqDG. I'm merging this now, I'll update the changelog entry as well.
Having to do this should be negated by implementing #1267

Your use case sounds cool 🙂

@yonaskolb yonaskolb merged commit 435c194 into yonaskolb:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants