Skip to content

Fix getting stuck and crashing#51

Merged
thelvis4 merged 1 commit intoyopeso:masterfrom
S2dentik:master
Dec 29, 2016
Merged

Fix getting stuck and crashing#51
thelvis4 merged 1 commit intoyopeso:masterfrom
S2dentik:master

Conversation

@S2dentik
Copy link
Copy Markdown
Contributor

  • Fix getting stuck when sending multiple requests to sourcekitd simultaneously from different threads.
  • Fix SIGABRT in SourceKitten when getting substructure.

@lexorus
Copy link
Copy Markdown
Contributor

lexorus commented Dec 26, 2016

Checks are failing 😥. Tested on my machine too.
This is because the test target settings are damaged and TaylorFrameworkTests cannot be launched. Check the changes in the settings, especially with Yaml.framework dependency.

@S2dentik
Copy link
Copy Markdown
Contributor Author

#worksOnMyMachine

@lexorus
Copy link
Copy Markdown
Contributor

lexorus commented Dec 26, 2016

@S2dentik did you tried to launch only TaylorFrameworkTests (by disabling TaylorIntegrationTests from the scheme)?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 26, 2016

Current coverage is 93.07% (diff: 92.85%)

Merging #51 into master will decrease coverage by 0.03%

@@             master        #51   diff @@
==========================================
  Files            61         61          
  Lines          1683       1690     +7   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1567       1573     +6   
- Misses          116        117     +1   
  Partials          0          0          

Powered by Codecov. Last update b9fee76...8452cdb

@lexorus
Copy link
Copy Markdown
Contributor

lexorus commented Dec 26, 2016

@S2dentik ok, working now after update. Thanks 🎉🎉🎉.

@lexorus lexorus added the bug label Dec 26, 2016
Copy link
Copy Markdown
Contributor

@lexorus lexorus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelvis4
Copy link
Copy Markdown
Contributor

thelvis4 commented Dec 27, 2016

@S2dentik About dependencies:
Please use Carthage everywhere we can use it (for SourceKitten and all its dependencies).
In TaylorFramework/Frameworks we keep just the frameworks that don't support Carthage.

To do this:

  1. Run carthage update
  2. Link TaylorFramework against the binaries from Carthage/Build/Mac
  3. Remove unnecessary frameworks from TaylorFramework/Frameworks

P.S. Current dependency management is not intuitive at all.

@thelvis4
Copy link
Copy Markdown
Contributor

@S2dentik I made the suggested changes, so you don't have to worry about them.

Thanks for investigating and coming with the fix. 👍

@thelvis4 thelvis4 merged commit 1d92a24 into yopeso:master Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants