Allow customization for syntax highlighting just like the themes

[MuntasirSZN]

Title ;)

[lazysegtree]

Note - For now we use ansichroma.HightlightString() function to generate highlighting based on file type. (https://github.com/yorukot/ansichroma), which uses "github.com/alecthomas/chroma"

[nkxxll]

Wouldn't it be nice to optionally add bat as previewer. bat already has all the themes and syntax highlighting. Just a thought...

[MuntasirSZN]

Wouldn't it be nice to optionally add bat as previewer. bat already has all the themes and syntax highlighting. Just a thought...

Yeah! That is a great approach! I think a plugin for bat will do, isn't it?

[nkxxll]

I dabled a bit so...see this code snippet

superfile/src/internal/model_render.go

Lines 698 to 709 in 0de468d

	// We know the format of file, and we can apply syntax highlighting
	if format != nil {
	background := ""
	if !Config.TransparentBackground {
	background = theme.FilePanelBG
	}
	fileContent, err = ansichroma.HightlightString(fileContent, format.Config().Name, theme.CodeSyntaxHighlightTheme, background)
	if err != nil {
	slog.Error("Error render code highlight", "error", err)
	return box.Render("\n --- " + icon.Error + " Error render code highlight ---")
	}
	}

You can incorporate bat like this

// We know the format of file, and we can apply syntax highlighting
if format != nil {
	// background := ""
	// if !Config.TransparentBackground {
	// 	background = theme.FilePanelBG
	// }
	// fileContent, err = ansichroma.HightlightString(fileContent, format.Config().Name, theme.CodeSyntaxHighlightTheme, background)
	batCmd := []string{"bat", itemPath, "-p", "-f"}
	cmd := exec.Command(batCmd[0], batCmd[1:]...)
	fileContentBytes, err := cmd.Output()
	if err != nil {
		slog.Error("Error render code highlight", "error", err)
		return box.Render("\n --- " + icon.Error + " Error render code highlight ---")
	}
	lines := bytes.Split(fileContentBytes, []byte{'\n'})
	if len(lines) > previewLine {
		fileContent = string(bytes.Join(lines[:previewLine], []byte{'\n'}))
	} else {
		fileContent = string(bytes.Join(lines, []byte{'\n'}))
	}
}

and it seems to work fine with syntax highlighting.
This is still rough around the edges but it works.

I have tokyonight as theme in bat and it looks a bit weird because I have set the background of my terminal darker but this is fixable.

[nkxxll]

Chroma styles has a list of available styles that can be chosen from. It is the same list as pygments here. Going forward you could only support the styles that are available in chroma or custom styles for chroma or plug in with bat and use the bat eco system for syntax highlighting. The question is not for this project would you rather stay only with chroma adding options for more/custom themes or would you rather use bat as proxy for syntax highlighting @MuntasirSZN. I would love to make a PR and work on that sounds like a fun task 😄.

[MuntasirSZN]

Chroma styles has a list of available styles that can be chosen from. It is the same list as pygments here. Going forward you could only support the styles that are available in chroma or custom styles for chroma or plug in with bat and use the bat eco system for syntax highlighting. The question is not for this project would you rather stay only with chroma adding options for more/custom themes or would you rather use bat as proxy for syntax highlighting @MuntasirSZN. I would love to make a PR and work on that sounds like a fun task 😄.

Ummmm, lets do bat. (My inside saying to do both)

[nkxxll]

@lazysegtree can this issue be closed now pr is through right?

[lazysegtree]

I think yes. @MuntasirSZN if you feel it can be closed, please close this issue.