Conversation
Member
|
Some things I noticed while doing some preliminary testing:
Some other things we should considers:
This is really exiting :). I'm also surprised by how good the call quality is. I hope I'll be more free in the coming weeks so I can do more testing and help with this as well... |
style: improve dialer design
fix: dialer screen crashing
# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/com/bnyro/contacts/ui/activities/MainActivity.kt # app/src/main/java/com/bnyro/contacts/ui/screens/MainAppContent.kt # app/src/main/java/com/bnyro/contacts/ui/screens/SettingsScreen.kt # app/src/main/res/values/strings.xml
This comment was marked as off-topic.
This comment was marked as off-topic.
Bnyro
commented
Apr 21, 2024
Bnyro
commented
Apr 21, 2024
Bnyro
commented
Apr 21, 2024
Bnyro
commented
Apr 21, 2024
Member
|
I think it will be easier if we could merge this PR now and work on the other features after merging. Apart from that, I believe that the dialer is stable enough to mark as an experimental opt-in feature. |
Member
Author
|
I agree on that, let's merge 👍 Before creating a new release we can just make a preference to opt-in for using it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
NOTES: