Create menu-2.html #81
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a better dropdown menu
Member
|
@hiteshrew can you add gif thumbnail to readme file? |
gaurovgiri
suggested changes
Oct 19, 2023
Contributor
gaurovgiri
left a comment
gaurovgiri
left a comment
There was a problem hiding this comment.
@hiteshrew Can you fix the formatting? The extra spacing and really not required. Use prettier to fix the formatting.
Author
|
Hahaha dude, it’s been 3 years.
Let it go lol.
…On Thu, 19 Oct 2023 at 12:10 PM, Gaurav Giri ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@hiteshrew <https://github.com/hiteshrew> Can you fix the formatting? The
extra spacing and really not required. Use prettier to fix the formatting.
—
Reply to this email directly, view it on GitHub
<#81 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN7IUO442G4I7P34FENF75DYADDOJAVCNFSM4KLV5TX2U5DIOJSWCZC7NNSXTPCQOVWGYUTFOF2WK43UKJSXM2LFO45TCNRYGY4DIMZUGIZA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
NamPNQ
reviewed
Oct 24, 2023
| <li id="b"><a href="#b">Web Programming</a> | ||
| <div> | ||
| <hr><strong>Frontend:</strong> <a href="#">JavaScript</a> | <a href="#">JQuery</a> | ||
| <hr><strong>Backend:</strong> <a href="#">Node.js<a> | <a href="#">PHP</a> |
Member
There was a problem hiding this comment.
Suggested change
| <hr><strong>Backend:</strong> <a href="#">Node.js<a> | <a href="#">PHP</a> | |
| <hr><strong>Backend:</strong> <a href="#">Node.js</a> | <a href="#">PHP</a> |
NamPNQ
reviewed
Oct 24, 2023
|
|
||
| .menu ul li div{ | ||
| text-align:left; | ||
| font: normal 11px |
Member
There was a problem hiding this comment.
Suggested change
| font: normal 11px | |
| font: normal 11px} |
NamPNQ
reviewed
Oct 24, 2023
| } | ||
| .menu ul li:hover{ | ||
|
|
||
| background:linear-gradient (top,#ffffff 0%, #f4f4f4 50%, #ededed 51%,#ffffff 100%); |
Member
There was a problem hiding this comment.
Suggested change
| background:linear-gradient (top,#ffffff 0%, #f4f4f4 50%, #ededed 51%,#ffffff 100%); | |
| background:linear-gradient(to top,#ffffff 0%, #f4f4f4 50%, #ededed 51%,#ffffff 100%); |
NamPNQ
reviewed
Oct 24, 2023
| position: absolute; | ||
| overflow: hidden; | ||
| z-index: 10000; | ||
| background:linear-gradient(top,#ffffff 0%, #f2f2f2 50%,#e1e1e1 51%,#f6f6f6 100%); |
Member
There was a problem hiding this comment.
Suggested change
| background:linear-gradient(top,#ffffff 0%, #f2f2f2 50%,#e1e1e1 51%,#f6f6f6 100%); | |
| background:linear-gradient(to top,#ffffff 0%, #f2f2f2 50%,#e1e1e1 51%,#f6f6f6 100%); |
Member
|
I just try it but look like it doesn't work, can you fix this @hiteshrew |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a better dropdown menu