APPS-7 : Automatically detect package manager and install dependencies on init#72
Merged
achaaoui-yc merged 7 commits intomainfrom Nov 21, 2024
Merged
APPS-7 : Automatically detect package manager and install dependencies on init#72achaaoui-yc merged 7 commits intomainfrom
achaaoui-yc merged 7 commits intomainfrom
Conversation
azuradara
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
APPS-7
I could not get this pr to be tested perfectly locally, so to qa it well, we need to follow some steps.
To know the package manager used by the user, I used this env var
npm_config_user_agentthat all package managers set. to know what each one of them puts in it, we need to:Steps
npm,pnpmoryarn, (eg,pnpm init @youcan/create-app)ps aux | grep create-app)npm_config_user_agent, (ps -Eww | grep <PID> | tr ' ' '\n' | grep npm_config_user_agent)QA Steps
Note
I am using --no-progress option fornpm install, bc it messes up the out put, it might be fixed, but still to figure it out if wanted.Installing dependencies...task seems out of style, to think of a better way to handle unloadable tasks.