YPE-1180 Add Android example app build tests#35
Conversation
|
I believe that the current failure on the added test is legit and shows the failures I was seeing before my changes in the other PR. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Greptile SummaryThis PR adds a new GitHub Actions workflow ( Confidence Score: 5/5Safe to merge — the workflow is well-structured with all previously raised concerns (timeout, permissions, Gradle caching, working directory) addressed. All P1 findings from prior review rounds have been resolved. The only remaining finding is a P2 style suggestion (missing No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub (PR to main)
participant Runner as ubuntu-latest Runner
participant Node as Node.js 20
participant Java as Java 17 (temurin)
participant Expo as Expo CLI (prebuild)
participant Gradle as Gradle (assembleDebug)
GH->>Runner: Trigger on pull_request
Runner->>Runner: Checkout repository
Runner->>Node: Setup Node.js 20 + npm cache
Runner->>Java: Setup Java 17 + Gradle cache
Runner->>Node: npm ci (root deps)
Runner->>Node: npm ci (example/ deps)
Runner->>Expo: npx expo prebuild (generates android/ + ios/)
Runner->>Gradle: ./gradlew assembleDebug (example/android)
Gradle-->>Runner: Build success / failure
Reviews (3): Last reviewed commit: "fix: cache and build" | Re-trigger Greptile |
bmanquen
left a comment
There was a problem hiding this comment.
I am learning about android and iOS so take my comments with a grain of salt.
|
Also I think we can probably test the android and ios builds in one github workflow file as long as they are in different jobs. |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Cameron Llewellyn <cameron.b.llewellyn@gmail.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Cameron Llewellyn <cameron.b.llewellyn@gmail.com>
fdb8dd4 to
27f5e9e
Compare
Description
We had broken example app builds. This adds the tests to build the Android app.
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Checklist
Greptile Summary
This PR adds a GitHub Actions workflow that builds the Android example app on every PR targeting
main, catching broken builds the way the existingexample_ios_build.ymlcatches iOS regressions. The workflow is well-structured — it has an explicitpermissions: contents: read, a 30-minute timeout, and leveragessetup-java's built-in Gradle caching, and correctly uses./gradlew assembleDebugdirectly fromexample/android.Confidence Score: 5/5
Safe to merge — all previous review concerns have been addressed and the only remaining finding is a minor P2 style suggestion.
The workflow correctly uses
./gradlew assembleDebugfromexample/android, has explicit least-privilege permissions, a 30-minute timeout, and Gradle caching viasetup-java. The sole remaining observation (missing--platform androidonexpo prebuild) is a non-blocking consistency suggestion that won't cause the workflow to fail on Ubuntu.No files require special attention.
Important Files Changed
expo prebuildis missing the--platform androidflag.Sequence Diagram
sequenceDiagram participant PR as Pull Request participant GH as GitHub Actions participant Ubuntu as ubuntu-latest runner participant Node as Node.js 20 participant Java as Java 17 (Temurin) participant Expo as expo prebuild participant Gradle as Gradle (assembleDebug) PR->>GH: Triggered on PR to main GH->>Ubuntu: Spin up runner Ubuntu->>Ubuntu: Checkout repository Ubuntu->>Node: Setup Node.js 20 (npm cache) Ubuntu->>Java: Setup Java 17 (Gradle cache) Ubuntu->>Node: npm ci (root deps) Ubuntu->>Node: npm ci (example/ deps) Node->>Expo: npx expo prebuild Expo-->>Ubuntu: Generate example/android/ native project Ubuntu->>Gradle: ./gradlew assembleDebug Gradle-->>Ubuntu: Build APK (debug) Ubuntu-->>GH: Report success/failure GH-->>PR: Build status checkPrompt To Fix All With AI
Reviews (4): Last reviewed commit: "fix: cache and build" | Re-trigger Greptile