feat: Update Kotlin SDK and fix all breaking changes#36
Merged
sidorchukandrew merged 2 commits intomainfrom Jan 31, 2026
Merged
feat: Update Kotlin SDK and fix all breaking changes#36sidorchukandrew merged 2 commits intomainfrom
sidorchukandrew merged 2 commits intomainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
Greptile OverviewGreptile SummaryThis PR updates the Kotlin SDK from version 0.5.0 to 0.6.0 and adapts the React Native SDK translation layer to match the upstream API changes. Key Changes:
Critical Issue:
Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant RN as React Native App
participant SDK as ReactNative SDK
participant API as YouVersion Platform SDK 0.6.0
participant Models as Data Models
Note over SDK,API: Language API Call Flow
RN->>SDK: Request languages(country)
SDK->>API: YouVersionApi.languages.languages(country)
API-->>SDK: List<Language>
SDK->>Models: Map to LanguageRecord
Note over Models: Maps defaultBibleVersionId → defaultBibleId
Models-->>SDK: List<LanguageRecord>
SDK-->>RN: Return language records
Note over SDK,API: Bible Version Data Flow
RN->>SDK: Request bible version
API-->>SDK: BibleVersion object
SDK->>Models: Map to BibleVersionRecord
Note over Models: copyrightLong → promotionalContent<br/>copyrightShort → copyright<br/>+ organizationId field
Models-->>SDK: BibleVersionRecord
SDK-->>RN: Return bible version
Note over SDK,API: Bible Book Data Flow
API-->>SDK: BibleBook object
SDK->>Models: Map to BibleBookRecord
Note over Models: usfm → id<br/>+ fullTitle field
Models-->>SDK: BibleBookRecord
Note over SDK,API: Bible Chapter Data Flow
API-->>SDK: BibleChapter object
SDK->>Models: Map to BibleChapterRecord
Note over Models: Removed bookUSFM, isCanonical
Models-->>SDK: BibleChapterRecord
Note over RN,SDK: Sign In Button Flow
RN->>SDK: Render SignInWithYouVersionButton
SDK->>API: SignInWithYouVersionButton(permissions)
Note over SDK: permissions: () → HashSet()
API-->>SDK: Render button
SDK-->>RN: Display button
|
android/src/main/java/com/youversion/reactnativesdk/views/YVPSignInWithYouVersionButton.kt
Show resolved
Hide resolved
android/src/main/java/com/youversion/reactnativesdk/views/YVPSignInWithYouVersionButton.kt
Show resolved
Hide resolved
18 tasks
mic-mart
approved these changes
Jan 31, 2026
Collaborator
mic-mart
left a comment
There was a problem hiding this comment.
Thanks @sidorchukandrew ! Looks good. Thanks for replying to the greptile comments. That was helpful.
jhampton
pushed a commit
that referenced
this pull request
Jan 31, 2026
|
🎉 This PR is included in version 0.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Breaking Changes
Breaking Change Details:
This PR updates to the newest Kotlin SDK. There are a number of fields that have been updated that our translation layer needs to reflect.
Checklist